Merge branch 'release/29.x'

* release/29.x: No issue. Fix PubMed test. #4192 - Upgrade dependencies
inception-project · Sep 25, 2023 · 11f7c1a · 11f7c1a
2 parents 56b9b43 + c4111d6
commit 11f7c1a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/inception/inception-dependencies/pom.xml b/inception/inception-dependencies/pom.xml
@@ -971,7 +971,7 @@
       <dependency>
         <groupId>org.xerial.snappy</groupId>
         <artifactId>snappy-java</artifactId>
-        <version>1.1.10.3</version>
+        <version>1.1.10.4</version>
       </dependency>
 
       <!-- JAXB DEPENDENCIES -->

diff --git a/...test/java/de/tudarmstadt/ukp/inception/externalsearch/pubmed/entrez/EntrezClientTest.java b/...test/java/de/tudarmstadt/ukp/inception/externalsearch/pubmed/entrez/EntrezClientTest.java
@@ -17,6 +17,8 @@
  */
 package de.tudarmstadt.ukp.inception.externalsearch.pubmed.entrez;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
@@ -38,18 +40,18 @@ public void thatESearchWorks() throws Exception
     {
         var results = sut.esearch("pmc", "asthma", 0, 10);
 
-        System.out.println(results);
+        // System.out.println(results);
 
-        // assertThat(results).isNotEmpty();
+        assertThat(results.getIdList()).isNotEmpty();
     }
 
     @Test
     public void thatEsummaryWorks() throws Exception
     {
         var results = sut.esummary("pmc", 6678417, 9507199);
 
-        System.out.println(results);
+        // System.out.println(results);
 
-        // assertThat(results).isNotEmpty();
+        assertThat(results.getDocSumaries()).isNotEmpty();
     }
 }
diff --git a/...c/test/java/de/tudarmstadt/ukp/inception/externalsearch/pubmed/pmcoa/PmcOaClientTest.java b/...c/test/java/de/tudarmstadt/ukp/inception/externalsearch/pubmed/pmcoa/PmcOaClientTest.java
@@ -42,10 +42,11 @@ public void setup() throws InterruptedException
     @Test
     public void thatBiocWorks() throws Exception
     {
-        String results = new String(sut.bioc(traits, "PMC8222896"), UTF_8);
+        String results = new String(sut.bioc(traits, "PMC7096989"), UTF_8);
 
         // System.out.println(results);
 
-        assertThat(results).contains("Longitudinal symptoms in asthmatic COVID‐19 patients.");
+        assertThat(results)
+                .contains("Asthma is the most common inflammatory disease of the lungs.");
     }
 }