Allow service port name override #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubel-ahammad
force-pushed
the
allow-service-port-name-override
branch
from
caac40c to
8f7657e
Compare
cpanato
requested changes
Sep 10, 2024
I added an option in the chart. So I believe it is a feature change and the new version should be 2.4.0. @cpanato what do you think? |
rubel-ahammad
force-pushed
the
allow-service-port-name-override
branch
from
24b462d to
acf7828
Compare
That is fine, the feature is not changing the actual behavior so we can consider a patch, but this is also fine Thanks for doing this! |
|
Signed-off-by: Rubel Ahammad <[email protected]> Signed-off-by: Rubel Ahammad <[email protected]>
Signed-off-by: Rubel Ahammad <[email protected]> Signed-off-by: Rubel Ahammad <[email protected]>
Signed-off-by: Rubel Ahammad <[email protected]>
Signed-off-by: Rubel Ahammad <[email protected]>
rubel-ahammad
force-pushed
the
allow-service-port-name-override
branch
from
f7a2069 to
076ab70
Compare
|
Hi, I have pushed the fix. Could you please review again?
…On Thu, 12 Sept 2024 at 09:02, Carlos Tadeu Panato Junior < ***@***.***> wrote:
Error: UPGRADE FAILED: template: inbucket/templates/service.yaml:29:22: executing "inbucket/templates/service.yaml" at <.Values.service.portName.http>: nil pointer evaluating interface {}.http
—
Reply to this email directly, view it on GitHub
<#41 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZZLWTBI35VAFOI3BI2W2TZWD737AVCNFSM6AAAAABN46KRQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBVGE3TEMJWGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #40