use a tag in the bats image #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanato
requested changes
Mar 13, 2024
| @@ -12,7 +12,7 @@ metadata: | |||
| spec: | |||
| containers: | |||
| - name: {{ .Release.Name }}-test | |||
| image: "bats/bats" | |||
| image: "bats/bats:v1.10.0" | |||
There was a problem hiding this comment.
Suggested change
| image: "bats/bats:v1.10.0" | |
| image: "bats/bats:v1.10.0@sha256:33d5909905442e39afdb29af693516f213ace6b8100045d408475d5bd15196cb" |
amitsagtani97
force-pushed
the
use_fixed_tag
branch
from
f614d81 to
50d2200
Compare
@cpanato Fixed :) |
cpanato
requested changes
Mar 18, 2024
cpanato
requested changes
May 17, 2024
amitsagtani97
force-pushed
the
use_fixed_tag
branch
from
5b8cc3d to
f34e7a5
Compare
@cpanato done :) |
|
you missed to sign-off the commit, (DCO Check) |
Signed-off-by: Amit Sagtani <[email protected]>
amitsagtani97
force-pushed
the
use_fixed_tag
branch
from
f34e7a5 to
29daa87
Compare
ahhh.. I missed that.. Fixed now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to bundle and deploy inbucket in a complete offline env, it returns because of not using a specific tag in the bats image.
Using a latest stable release tag, instead of latest by default.