Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tolerations and local storage to the deployment #26

Merged
merged 3 commits into from
May 2, 2024

Conversation

VoroAndjaro
Copy link
Contributor

The deployment has affinity in the form of nodeSelector but not tolerations for taints. This PR adds optional tolerations to the deployment resource.

Also, an optional persistent volume claim is created if enabled in the values; this allows the deployment to have a persistent storage to keep the emails, in case it is required.
The environment variables for the storage have to be set manually in the values like:

extraEnv:
  INBUCKET_STORAGE_TYPE: "file"
  INBUCKET_STORAGE_PARAMS: "path:/storage"

Copy link
Collaborator

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this PR

helm-charts/inbucket/Chart.yaml Outdated Show resolved Hide resolved
@cpanato
Copy link
Collaborator

cpanato commented Feb 29, 2024

Error: UPGRADE FAILED: template: inbucket/templates/pvc.yaml:1:14: executing "inbucket/templates/pvc.yaml" at <.Values.persistence.enabled>: nil pointer evaluating interface {}.enabled

@cpanato cpanato merged commit b6d541f into inbucket:main May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants