Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix web greeting file path #19

Closed
wants to merge 1 commit into from

Conversation

josedev-union
Copy link

No description provided.

Signed-off-by: josedev-union <[email protected]>
Copy link
Collaborator

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@jhillyerd
Copy link
Contributor

This is not correct. Greeting is the the "message of the day" content, which Inbucket embeds within the front page, it's meant to be customized by the user. ui/index.html is essentially the loader for the entire "single page webapp" that is Inbucket's UI.

@cpanato
Copy link
Collaborator

cpanato commented Nov 21, 2023

oh, thanks @jhillyerd so we will close this pr

@josedev-union
Copy link
Author

This is not correct. Greeting is the the "message of the day" content, which Inbucket embeds within the front page, it's meant to be customized by the user. ui/index.html is essentially the loader for the entire "single page webapp" that is Inbucket's UI.

@jhillyerd thanks for clarifying. But inbucket web console is not working with the default configuration because of unexisting greeting.html file.
I think if that greeting file is optional, the server should work. Or if that is mandatory, the container image should include a default file so the helm chart works out of the box?

@jhillyerd
Copy link
Contributor

I've created #20 as a place to discuss

@corey-aloia
Copy link
Contributor

I just noticed this PR.... I opened a similar one yesterday: #23

I believe the PR I open is correct, as /config is what is used when running the container. I also have tested this locally. See: https://github.com/inbucket/inbucket/blob/1b5a783dbd26677b3d73d38c7e7113dc12d4194a/etc/docker/defaults/start-inbucket.sh#L7

@jhillyerd
Copy link
Contributor

obsoleted by #23

@jhillyerd jhillyerd closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants