-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
33 adapt write dwc for use by opencpu #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `write_dwc()` function
Add `write_dwc()` function
Update return value for `write_dwc()`
Add `write_dwc()` function
9 tasks
PietrH
added
enhancement
New feature or request
dev
Improvements to development workflow
client-side
labels
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33
Resolves #35
This function does not mimic the behaviour of
etn
'swrite_dwc()
one to one, instead will only return a list of dataframes. The handling of writing to a local file, including creating a directory if necessary will need to handled by the client.Motivation of changes + outlook on future
This function actually has two steps,
With a progress message in the middle. Because the API will handle this in a single request, the progress message doesn't make much sense and was removed.
We could retain this message if we have the client handle the first call to
get_animal_projects()
and change the inputs toetnservice
'swrite_dwc()
to the parsed output ofget_animal_projects()
. However this would result in a mismatch between the arguments thatwrite_dwc()
accepts betweenetn
andetnservice
, and thus break a future possible generic sql helper or the option of inheriting documentation between the packages. (see comments in #33)This doesn't seem worth it to me. Alternatively we could create a new function just for
etnservice
, eg.get_dwc()
with input arguments based onget_animal_projects
, and retain awrite_dwc()
inetnservice
that isn't actually used by the client but does allow for inheritance of documentation or use by a (possible future) generic sql helper. For discussion on this last helper, see inbo/etn#280TODO