Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port write_dwc() to use the API #302

Merged
merged 53 commits into from
Sep 24, 2024
Merged

Port write_dwc() to use the API #302

merged 53 commits into from
Sep 24, 2024

Commits on Sep 12, 2024

  1. split into sql helper and api forward

    @PietrH
    PietrH committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    eff907b View commit details
    Browse the repository at this point in the history

  2. devtools::document()

    @PietrH
    PietrH committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ee49b2d View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. directory is no longer deprecated, but is not passed to API

    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a096a2c View commit details
    Browse the repository at this point in the history

  2. allow not passing partent function arguments to sql/api helper

    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    626c51b View commit details
    Browse the repository at this point in the history

  3. devtools::document()

    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7467dee View commit details
    Browse the repository at this point in the history

  4. Style

    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d8950fa View commit details
    Browse the repository at this point in the history

  5. Setup for writing out

    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a55e0ec View commit details
    Browse the repository at this point in the history

  6. allow non existing paths

    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7152d3d View commit details
    Browse the repository at this point in the history

  7. also allow no ignored arguments

    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    06e2bfc View commit details
    Browse the repository at this point in the history

  8. implement NULL fix from etn, write out csv:not list, return list over… 

    … sql
    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3761337 View commit details
    Browse the repository at this point in the history

  9. don't use con in tests: deprecated

    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0109932 View commit details
    Browse the repository at this point in the history

  10. devtools::document()

    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ab36d0b View commit details
    Browse the repository at this point in the history

  11. split test into API and SQL file

    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    91ec15b View commit details
    Browse the repository at this point in the history

  12. set usage of api explicitly: retain test behaviour even if default be… 

    …havior changes
    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    66251d6 View commit details
    Browse the repository at this point in the history

  13. use cached api response for demer

    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e4e71c4 View commit details
    Browse the repository at this point in the history

  14. Add cached response for write_dwc()

    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4e05e01 View commit details
    Browse the repository at this point in the history

  15. filter opencpu temp key in attempt to get vcr to work

    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    f088ad8 View commit details
    Browse the repository at this point in the history

  16. Filtering opencpu temp key doesn't stop mismatching on uri

    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d2b9cf9 View commit details
    Browse the repository at this point in the history

  17. encapsulate all tests in single casette

    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7d6c319 View commit details
    Browse the repository at this point in the history

  18. cache request with writing and without writing to disk

    @PietrH
    PietrH committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8829b8f View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Close connection after query, avoid connection leak, free resources

    @PietrH
    PietrH committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    35d095e View commit details
    Browse the repository at this point in the history

  2. restore default directory so write to wd: e7c090e

    @PietrH
    PietrH committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4672ca3 View commit details
    Browse the repository at this point in the history

  3. update news on invisible return

    @PietrH
    PietrH committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4c5dd9c View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. rename to single test per function

    @PietrH
    PietrH committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9dddc71 View commit details
    Browse the repository at this point in the history

  2. Add prefix so you can tell if api or sql function fails

    @PietrH
    PietrH committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2ec46c6 View commit details
    Browse the repository at this point in the history

  3. Add API tests, need to be in vcr curly brackets to use cached response

    @PietrH
    PietrH committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    57de989 View commit details
    Browse the repository at this point in the history

  4. devtools::document()

    @PietrH
    PietrH committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9f8ae9d View commit details
    Browse the repository at this point in the history

  5. remove seperate API tests, now in single file with all tests for writ… 

    …e_dwc()
    @PietrH
    PietrH committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    cb42db3 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. update test reference for list_animal_ids()

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    95075c0 View commit details
    Browse the repository at this point in the history

  2. update snapshots

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9bb4250 View commit details
    Browse the repository at this point in the history

  3. test is malformed; this should never have worked? Did testthat change?

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e98c111 View commit details
    Browse the repository at this point in the history

  4. Make test empty so it is flagged as skipped as a reminder to follow up

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c8276a8 View commit details
    Browse the repository at this point in the history

  5. update cached response to use json instead of rda

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    798abfd View commit details
    Browse the repository at this point in the history

  6. connect_to_etn() is no longer used

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1b1110d View commit details
    Browse the repository at this point in the history

  7. don't test for invalid connection, should be tested for `check_connec… 

    …tion()``
    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    604dbb9 View commit details
    Browse the repository at this point in the history

  8. use cached response for specific deployment (small file)

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    78c6ff8 View commit details
    Browse the repository at this point in the history

  9. switch back to complete response: needed for other tests

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f2baf7e View commit details
    Browse the repository at this point in the history

  10. switch back to complete response: needed for other tests

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bf229c0 View commit details
    Browse the repository at this point in the history

  11. Merge branch '297-port-write-dwc-api' of github.com:inbo/etn into 297… 

    …-port-write-dwc-api
    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ceb7f1e View commit details
    Browse the repository at this point in the history

  12. Add skip message referring to issue

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    37f2ce8 View commit details
    Browse the repository at this point in the history

  13. split API/SQL tests, add more API response caching

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e19a61a View commit details
    Browse the repository at this point in the history

  14. split API/SQL tests, add more API response caching

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    87a8b3a View commit details
    Browse the repository at this point in the history

  15. Merge branch '297-port-write-dwc-api' of github.com:inbo/etn into 297… 

    …-port-write-dwc-api
    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    128a38c View commit details
    Browse the repository at this point in the history

  16. Remove sql helper tests, covered by splitting tests in api and sql ve… 

    …rsions
    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9aafd55 View commit details
    Browse the repository at this point in the history

  17. fix typo

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9157fb9 View commit details
    Browse the repository at this point in the history

  18. functions with brackets so it's clear it's a function

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a6d41c6 View commit details
    Browse the repository at this point in the history

  19. set askpass as dep: for credential storage

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    01e5793 View commit details
    Browse the repository at this point in the history

  20. add parameters for api and connection

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5bc110a View commit details
    Browse the repository at this point in the history

  21. usethis::use_lifecycle()

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bca86ec View commit details
    Browse the repository at this point in the history

  22. inherit params: connection and api from list_animal_ids()

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d3958a8 View commit details
    Browse the repository at this point in the history

  23. devtools::document()

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    75dc2b2 View commit details
    Browse the repository at this point in the history

  24. remove connection roxygen docs, inherit connection and api args… 

    … from `list_animal_ids()``
    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b01f94d View commit details
    Browse the repository at this point in the history

  25. devtools::document()

    @PietrH
    PietrH committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a3f80f1 View commit details
    Browse the repository at this point in the history