feat: rework TraceId for honeycomb (breaking change) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is an example of the kinds of issues which arise with the current API - double parsing to and from intermediate values including strings ... 😬 |
Now can be any opaque string as specified by Honeycomb but will be generated as a UUID V4 and also prefer to be stored as a UUID. Adds many ways of converting to and from `TraceId`.
Fishrock123
force-pushed
the
rework-traceid
branch
from
9255694 to
bac9303
Compare
|
This has conflicts because #7 never considered that Trace IDs may not be able to be a |
|
Also, the lack of this is causing my team bugs in our services because this library disregards honeycomb's insistence that id's can be anything. Refs: eaze/preroll#18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now can be any opaque string as specified by Honeycomb but will be generated as a UUID V4 and also prefer to be stored as a UUID.
Adds many ways of converting to and from
TraceId.This is a breaking change because
format!("{}", trace_id)now returns a more compressed string encoding of a u128 if you useTraceId::generate().