V2 rain #5
Closed
V2 rain #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshowers
reviewed
Mar 7, 2020
.circleci/config.yml
Outdated
| @@ -58,7 +58,7 @@ jobs: | |||
| name: Install and configure gh-pages | |||
| command: | | |||
| npm install -g --silent [email protected] | |||
| git config user.email "pkinsky+ci-build@gmail.com" | |||
| git config user.email "inanna+ci-build@recursion.wtf" | |||
.gitignore
Outdated
| @@ -1,3 +1,5 @@ | |||
| /target | |||
| **/*.rs.bk | |||
| Cargo.lock | |||
| honeycomb.key | |||
| tracing-honeycomb/proptest-regressions/* | |||
There was a problem hiding this comment.
newline at end of file (configure your editor maybe?)
Cargo.toml
Outdated
| "tracing-distributed", | ||
| "tracing-honeycomb", | ||
| ] |
There was a problem hiding this comment.
still needs a newline at EOF (maybe configure this in your editor?)
tracing-distributed/README.md
Outdated
|
|
||
| As a tracing layer, `TelemetryLayer` can be composed with other layers to provide stdout logging, filtering, etc. | ||
|
|
||
| This crate is primarily intended to be used by people implementing their own backends. A concrete implementation using honeycomb.io as a backend is available at (TODO: link to tracing-honeycomb). |
tracing-distributed/README.md
Outdated
|
|
||
| This crate is primarily intended to be used by people implementing their own backends. A concrete implementation using honeycomb.io as a backend is available at (TODO: link to tracing-honeycomb). | ||
|
|
||
| ## Implementation note |
sunshowers
approved these changes
Apr 6, 2020
.circleci/config.yml
Outdated
Comment on lines
81
to
83
| # filters: | ||
| # branches: | ||
| # only: master |
Cargo.toml
Outdated
| "tracing-distributed", | ||
| "tracing-honeycomb", | ||
| ] |
There was a problem hiding this comment.
still needs a newline at EOF (maybe configure this in your editor?)
README.md
Outdated
|
|
||
| tracing subscriber for use with honeycomb.io distributed tracing. Supports generating random trace IDs or recording known trace IDs on the current span. | ||
| [](LICENSE) |
tracing-honeycomb/README.md
Outdated
| Add the following to your Cargo.toml to get started. | ||
|
|
||
| ```toml | ||
| tracing-honeycomb = 0.1.0-alpha-1 |
There was a problem hiding this comment.
needs quotes around the version number, and also "0.1.0"?
tracing-honeycomb/Cargo.toml
Outdated
| @@ -0,0 +1,26 @@ | |||
| [package] | |||
| name = "tracing-honeycomb" | |||
| version = "0.1.0-alpha-1" | |||
tracing-honeycomb/README.md
Outdated
|
|
||
| ### Testing | ||
|
|
||
| Since `TraceCtx::current_trace_ctx` and `TraceCtx::record_on_current_span` can be expected to return `Ok` as long as some `TelemetryLayer` has been registered as part of the layer/subscriber stack and the current span is active, it's valid to `.expect` them to always succeed & to panic if they do not. However, you probably don't want to publish telemetry while running unit or integration tests. |
sunshowers
approved these changes
Apr 7, 2020
tracing-distributed/README.md
Outdated
| @@ -1,4 +1,4 @@ | |||
| [](https://crates.io/crates/tracing-distributed) [](https://docs.rs/tracing-distributed/) [](https://inanna-malick.github.io/honeycomb-tracing/tracing_distributed/)[](../LICENSE) | |||
| [](https://crates.io/crates/tracing-distributed) [](https://docs.rs/tracing-distributed/) [](https://inanna-malick.github.io/honeycomb-tracing/tracing_distributed/)[](../LICENSE)[](https://app.circleci.com/pipelines/github/inanna-malick/honeycomb-tracing) | |||
There was a problem hiding this comment.
the alt text inanna-malick should be something like "CircleCI status"
tracing-distributed/README.tpl
Outdated
| @@ -1,4 +1,4 @@ | |||
| [](https://crates.io/crates/tracing-distributed) [](https://docs.rs/tracing-distributed/) [](https://inanna-malick.github.io/honeycomb-tracing/tracing_distributed/)[](../LICENSE) | |||
| [](https://crates.io/crates/tracing-distributed) [](https://docs.rs/tracing-distributed/) [](https://inanna-malick.github.io/honeycomb-tracing/tracing_distributed/)[](../LICENSE)[](https://app.circleci.com/pipelines/github/inanna-malick/honeycomb-tracing) | |||
tracing-honeycomb/README.md
Outdated
| @@ -1,4 +1,4 @@ | |||
| [](https://crates.io/crates/tracing-honeycomb) [](https://docs.rs/tracing-honeycomb/) [](https://inanna-malick.github.io/honeycomb-tracing/tracing_honeycomb/)[](../LICENSE) | |||
| [](https://crates.io/crates/tracing-honeycomb) [](https://docs.rs/tracing-honeycomb/) [](https://inanna-malick.github.io/honeycomb-tracing/tracing_honeycomb/)[](../LICENSE)[](https://app.circleci.com/pipelines/github/inanna-malick/honeycomb-tracing) | |||
tracing-honeycomb/README.tpl
Outdated
| @@ -1,4 +1,4 @@ | |||
| [](https://crates.io/crates/tracing-honeycomb) [](https://docs.rs/tracing-honeycomb/) [](https://inanna-malick.github.io/honeycomb-tracing/tracing_honeycomb/)[](../LICENSE) | |||
| [](https://crates.io/crates/tracing-honeycomb) [](https://docs.rs/tracing-honeycomb/) [](https://inanna-malick.github.io/honeycomb-tracing/tracing_honeycomb/)[](../LICENSE)[](https://app.circleci.com/pipelines/github/inanna-malick/honeycomb-tracing) | |||
tracing-honeycomb/README.md
Outdated
| Add the following to your Cargo.toml to get started. | ||
|
|
||
| ```toml | ||
| tracing-honeycomb = 0.1.0-alpha-1 |
tracing-honeycomb/README.tpl
Outdated
| Add the following to your Cargo.toml to get started. | ||
|
|
||
| ```toml | ||
| tracing-honeycomb = {{version}} |
|
Anything holding this up? It seems most comments have been addressed. I think it would be ideal to get this out first and then iterate on a 0.3 soon from the open PRs. |
|
This PR can be closed, the main branch is more up to date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR so rain can leave comments