Solved problems with php data types: #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methods.json: method "updateInventory", param "products": changed type since stringJSON isn't a valid PHP data type, which makes the validations fail RequestValidator: Now changing $type to float if float is expected and int is given, since PHP converts floats with no decimals to integers. Here is an example: -> If you provided the price 19.95 that worked -> If you provided the price 20.00 that didn't work
…t handle arrays properly
updated version
releasing testversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
methods.json:
method "updateInventory", param "products":
changed type since stringJSON isn't a valid PHP data type, which makes the validations fail
RequestValidator:
Now changing $type to float if float is expected and int is given, since PHP converts floats with no decimals to integers. Here is an example:
-> If you provided the price 19.95 that worked
-> If you provided the price 20.00 that didn't work