Ferigis.66.add from ctx #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbrujohalcon
requested changes
Feb 24, 2017
test/sr_sessions_SUITE.erl
Outdated
| value = sr_state:retrieve(key, SrState2, not_found), | ||
| SrState3 = sr_state:remove(key, SrState2), | ||
| not_found = sr_state:retrieve(key, SrState3, not_found), | ||
| CowboyReq = fake_cowboy_req(), |
There was a problem hiding this comment.
Can we use the functions in sr_request in a super-dumb echo handler/module with the following function?
from_ctx(#{req := Req}) ->
#{headers => sr_request:headers(Req),
path => sr_request:path(Req),
bindings => sr_request:bindings(Req)
}.My goal is to test these new features by actually using them, not just for coverage completeness
test/sr_sessions_SUITE.erl
Outdated
| , #{agent => <<"a1">>}), | ||
| [_] = meck:unload(), | ||
|
|
||
| ct:comment("Functions coverage"), |
There was a problem hiding this comment.
Make it clear that what you're actually testing is sr_state:remove here.
elbrujohalcon
approved these changes
Feb 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[close #66]