Create sumo_single_entity_handler #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| -spec handle_get(cowboy_req:req(), state()) -> | ||
| {iodata(), cowboy_req:req(), state()}. | ||
| handle_get(Req, State) -> | ||
| #{opts := #{model := Model}, entity := Entity} = State, |
There was a problem hiding this comment.
Although it's true that at this point not much can go wrong, the other handle functions are wrapped in a try catch for unforseen exceptions and to return a proper 500 error, should this one do the same or is it overengineering?
There was a problem hiding this comment.
Our experience dictates that it's impossible to get this function to throw an exception. The main difference is the lack of access to databases or repositories here.
igaray
added a commit
that referenced
this pull request
Nov 23, 2015
…ntity_hand Create sumo_single_entity_handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has to be built on trails and it has to provide the following endpoints:
GET /[entities]/:id- return an entityPUT /[entities]/:id- creates/updates a new entityDELETE /[entities]/:id- deletes an entity