Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing option in type spec sr_json: json() #79

Closed
cabol opened this issue Mar 10, 2017 · 0 comments · Fixed by #81
Closed

Missing option in type spec sr_json: json() #79

cabol opened this issue Mar 10, 2017 · 0 comments · Fixed by #81

Comments

@cabol
Copy link
Contributor

cabol commented Mar 10, 2017

The type spec sr_json:json() (https://github.com/inaka/sumo_rest/blob/master/src/sr_json.erl#L11) should consider more valid JSON options like: [binary() | number() | ...] – might be others
ferigis added a commit that referenced this issue Mar 10, 2017
@ferigis
[#79] missing spec added
db212da
@ferigis ferigis mentioned this issue Mar 10, 2017
Merged
ferigis added a commit that referenced this issue Mar 10, 2017
@ferigis
[#79] PR comments fixed
22a157f
ferigis added a commit that referenced this issue Mar 10, 2017
@ferigis
[#79] More PR comments fixed
cf2db90
@cabol cabol closed this as completed in #81 Mar 10, 2017
cabol added a commit that referenced this issue Mar 10, 2017
@cabol
Merge pull request #81 from inaka/ferigis.79.missing_spec
aa16b64 
[#79] missing spec added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#79] missing spec added inaka/sumo_rest
1 participant
@cabol