Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error results from sumo_rest_doc's update callback are improperly handled #44

Closed
elbrujohalcon opened this issue Sep 13, 2016 · 0 comments · Fixed by #46
Closed

Error results from sumo_rest_doc's update callback are improperly handled #44

elbrujohalcon opened this issue Sep 13, 2016 · 0 comments · Fixed by #46
Assignees
@ferigis

Comments

@elbrujohalcon
Copy link
Member

While error results from Module:from_json are encoded with sr_json:error, error results from Module:update are not. They should both behave in the same way.
@ferigis ferigis self-assigned this Sep 13, 2016
ferigis added a commit that referenced this issue Sep 13, 2016
@ferigis
[#44] update error handled with sr_json:error/1
5d712a6
@ferigis ferigis mentioned this issue Sep 13, 2016
Merged
@cabol cabol closed this as completed in #46 Sep 14, 2016
cabol added a commit that referenced this issue Sep 14, 2016
@cabol
Merge pull request #46 from inaka/ferigis.44.update_error
0cc51f1 
[#44] update error handled with sr_json:error/1
@elbrujohalcon elbrujohalcon mentioned this issue Oct 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferigis ferigis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#44] update error handled with sr_json:error/1 inaka/sumo_rest
2 participants
@elbrujohalcon @ferigis