Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Drumsep MDX23C model by jarredou/aufr33 #5

Open
deton24 opened this issue Jul 4, 2024 · 5 comments
Open

New Drumsep MDX23C model by jarredou/aufr33 #5

deton24 opened this issue Jul 4, 2024 · 5 comments

Comments

@deton24
Copy link

deton24 commented Jul 4, 2024

https://docs.google.com/document/d/17fjNvJzj8ZGSer7c7OFe_CNfUKbAxEh_OBv94ZdRG5c/edit#heading=h.2u19k7ty9b00

Works with UVR. Colab attached.
Better SDR than the original Drumsep. Expanded dataset and better model architecture.

Still, I'd recommend using only on (e.g. separated) drums.

@ozzy-zig
Copy link

https://docs.google.com/document/d/17fjNvJzj8ZGSer7c7OFe_CNfUKbAxEh_OBv94ZdRG5c/edit#heading=h.2u19k7ty9b00

Works with UVR. Colab attached. Better SDR than the original Drumsep. Expanded dataset and better model architecture.

Still, I'd recommend using only on (e.g. separated) drums.

How do you get the new model to run in UVR? It always give me a constructor error.

@deton24
Copy link
Author

deton24 commented Jul 15, 2024 via email

@ozzy-zig
Copy link

Tried without GPU Conversion; no luck there. Also made sure I had the two proper files for the new model.
Given that the original drumsep was filed under demucs, I did the same for this model.
If this error is something silly and easily resolved, I do apologize.

Last Error Received:

Process: Demucs

If this error persists, please contact the developers with the error details.

Raw Error Details:

ConstructorError: "could not determine a constructor for the tag 'tag:yaml.org,2002:python/tuple'
in "C:\Users\USER\AppData\Local\Programs\Ultimate Vocal Remover\models\Demucs_Models\v3_v4_repo\aufr33-jarredou_DrumSep_model_mdx23c_ep_141_sdr_10.8059.yaml", line 54, column 16"
Traceback Error: "
File "UVR.py", line 6638, in process_start
File "separate.py", line 834, in seperate
File "demucs\pretrained.py", line 81, in get_model
File "demucs\repo.py", line 148, in get_model
File "demucs\repo.py", line 127, in get_model
File "yaml_init_.py", line 125, in safe_load
File "yaml_init_.py", line 81, in load
File "yaml\constructor.py", line 51, in get_single_data
File "yaml\constructor.py", line 60, in construct_document
File "yaml\constructor.py", line 413, in construct_yaml_map
File "yaml\constructor.py", line 218, in construct_mapping
File "yaml\constructor.py", line 143, in construct_mapping
File "yaml\constructor.py", line 100, in construct_object
File "yaml\constructor.py", line 427, in construct_undefined
"

Error Time Stamp [2024-07-15 06:52:08]

Full Application Settings:

vr_model: Choose Model
aggression_setting: 5
window_size: 512
mdx_segment_size: 256
batch_size: Default
crop_size: 256
is_tta: False
is_output_image: False
is_post_process: False
is_high_end_process: False
post_process_threshold: 0.2
vr_voc_inst_secondary_model: No Model Selected
vr_other_secondary_model: No Model Selected
vr_bass_secondary_model: No Model Selected
vr_drums_secondary_model: No Model Selected
vr_is_secondary_model_activate: False
vr_voc_inst_secondary_model_scale: 0.9
vr_other_secondary_model_scale: 0.7
vr_bass_secondary_model_scale: 0.5
vr_drums_secondary_model_scale: 0.5
demucs_model: aufr33-jarredou_DrumSep_model_mdx23c_ep_141_sdr_10.8059
segment: Default
overlap: 0.25
overlap_mdx: Default
overlap_mdx23: 8
shifts: 2
chunks_demucs: Auto
margin_demucs: 44100
is_chunk_demucs: False
is_chunk_mdxnet: False
is_primary_stem_only_Demucs: False
is_secondary_stem_only_Demucs: False
is_split_mode: True
is_demucs_combine_stems: True
is_mdx23_combine_stems: True
demucs_voc_inst_secondary_model: No Model Selected
demucs_other_secondary_model: No Model Selected
demucs_bass_secondary_model: No Model Selected
demucs_drums_secondary_model: No Model Selected
demucs_is_secondary_model_activate: False
demucs_voc_inst_secondary_model_scale: 0.9
demucs_other_secondary_model_scale: 0.7
demucs_bass_secondary_model_scale: 0.5
demucs_drums_secondary_model_scale: 0.5
demucs_pre_proc_model: No Model Selected
is_demucs_pre_proc_model_activate: False
is_demucs_pre_proc_model_inst_mix: False
mdx_net_model: Choose Model
chunks: Auto
margin: 44100
compensate: Auto
denoise_option: None
is_match_frequency_pitch: True
phase_option: Automatic
phase_shifts: None
is_save_align: False
is_match_silence: True
is_spec_match: False
is_mdx_c_seg_def: False
is_invert_spec: False
is_deverb_vocals: False
deverb_vocal_opt: Main Vocals Only
voc_split_save_opt: Lead Only
is_mixer_mode: False
mdx_batch_size: Default
mdx_voc_inst_secondary_model: No Model Selected
mdx_other_secondary_model: No Model Selected
mdx_bass_secondary_model: No Model Selected
mdx_drums_secondary_model: No Model Selected
mdx_is_secondary_model_activate: False
mdx_voc_inst_secondary_model_scale: 0.9
mdx_other_secondary_model_scale: 0.7
mdx_bass_secondary_model_scale: 0.5
mdx_drums_secondary_model_scale: 0.5
is_save_all_outputs_ensemble: True
is_append_ensemble_name: False
chosen_audio_tool: Manual Ensemble
choose_algorithm: Min Spec
time_stretch_rate: 2.0
pitch_rate: 2.0
is_time_correction: True
is_gpu_conversion: False
is_primary_stem_only: False
is_secondary_stem_only: False
is_testing_audio: False
is_auto_update_model_params: True
is_add_model_name: False
is_accept_any_input: False
is_task_complete: False
is_normalization: False
is_use_opencl: False
is_wav_ensemble: False
is_create_model_folder: False
mp3_bit_set: 320k
semitone_shift: 0
save_format: WAV
wav_type_set: PCM_16
device_set: Default
help_hints_var: True
set_vocal_splitter: No Model Selected
is_set_vocal_splitter: False
is_save_inst_set_vocal_splitter: False
model_sample_mode: False
model_sample_mode_duration: 30
demucs_stems: All Stems
mdx_stems: All Stems

@deton24
Copy link
Author

deton24 commented Jul 15, 2024 via email

@inagoy
Copy link
Owner

inagoy commented Jul 23, 2024

https://docs.google.com/document/d/17fjNvJzj8ZGSer7c7OFe_CNfUKbAxEh_OBv94ZdRG5c/edit#heading=h.2u19k7ty9b00

Works with UVR. Colab attached. Better SDR than the original Drumsep. Expanded dataset and better model architecture.

Still, I'd recommend using only on (e.g. separated) drums.

Great job, @deton24 ! Glad to see a new model that performs so well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants