Update layout expiry behavior #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasaky
requested changes
Jul 12, 2023
|
Current issue: verifylib.py is having trouble comparing the two mocked dates as one is timezone aware and the other date is not. |
adityasaky
requested changes
Jul 25, 2023
adityasaky
reviewed
Jul 25, 2023
SpencerKlem
force-pushed
the
SpencerMainBranch
branch
from
10bd742 to
b7dbaac
Compare
adityasaky
changed the title
SpencerKlem
force-pushed
the
SpencerMainBranch
branch
from
b7dbaac to
c402570
Compare
adityasaky
requested changes
Jul 31, 2023
SpencerKlem
force-pushed
the
SpencerMainBranch
branch
2 times, most recently
from
8218d2d to
17f12ed
Compare
Previously, the layout was considered to be expired if the current time was after the timestamp in the layout. Now, the layout is considered to be expired from the time specified in the layout onwards. Signed-off-by: Spencer Klem <[email protected]>
adityasaky
approved these changes
Aug 1, 2023
SpencerKlem
force-pushed
the
SpencerMainBranch
branch
from
17f12ed to
d8a3b4a
Compare
|
Great work, @SpencerKlem! |
This was referenced Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the fields below to submit a pull request. The more information
that is provided, the better.
Fixes issue #545:
Description of the changes being introduced by the pull request:
Adding test cases, has bug
Please verify and check that the pull request fulfills the following
requirements: