-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cleanup] Move _redirects from public to static #51
[cleanup] Move _redirects from public to static #51
Conversation
✅ Deploy Preview for in-toto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Patrice Chalin <[email protected]>
Signed-off-by: Patrice Chalin <[email protected]>
Signed-off-by: Patrice Chalin <[email protected]>
45d1e4a
to
7d03de1
Compare
Signed-off-by: Patrice Chalin <[email protected]>
/cc @marcelamelara @steiza - FYI, so that you're aware that the canonical source of the _redirects file has changed. |
@DarikshaAnsari - we'll need to ensure that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Moves
_redirects
frompublic
tostatic
👍
- Adjusts
layouts/partials/css.html
so that it creates a production build only in production (whenhugo.IsProduction
is true)
TBH, I can't tell if this is correct. Should I see a difference in the preview build? It looks like it does use the production css link (w/ hash):
<link rel="stylesheet" href="/css/style.94f9acd6bd00126cfa5eeb849dbf3cc631715b317a956d7516a0d3e4e1c1cef7.css" integrity_no="sha256-lPms1r0AEmz6XuuEnb88xjFxWzF6lW11FqDT5OHBzvc=">
- Adds NPM scripts to build and serve the website. Note that these scripts aren't used by the Netlify build commands yet.
Are these commands also for devs to build locally? If so, should we update our CONTRIBUTING.md? It does not have to be part of this pr.
💯 for providing links here.
Signed-off-by: Patrice Chalin <[email protected]>
Right, I had not enabled the scripts for use by Netlify. I've added that change so that you can see the effect by viewing source of the preview. Let me know what you think.
Both for use by Netlify and devs. I've updated
👍🏻 |
Signed-off-by: Patrice Chalin <[email protected]>
Looks like expected now. Thanks! |
Signed-off-by: Patrice Chalin <[email protected]>
public
directory #43_redirects
frompublic
tostatic
layouts/partials/css.html
so that it creates a production build only in production (whenhugo.IsProduction
is true)Redirect tests