-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add v1?draft slsa provenance definition #200
Conversation
Signed-off-by: Asra Ali <[email protected]>
Signed-off-by: Asra Ali <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We can keep the issue open and change it to remove draft
once finalized.
I'd prefer to leave it open as a draft to avoid someone accidentally using a non tagged version. @asraa wdyt? |
Right now the format is in The reason I'd like it (even if pushed to a branch?) is that it blocks us from drafting tooling until the spec goes GA, where it would be nice to be developing alpha tooling while it still is to test its use-ability. WDYT about the branch idea? |
Gotcha, let me review the status of |
I agree. Would be useful to start updating tools to meet the spec. |
Done! Thanks @asraa! |
Thank you all! I appreciate having a basis :) |
Signed-off-by: Asra Ali [email protected]
Fixes issue:
Related #197
Description:
Implements the
v1?draft
SLSA provenance spec. I expect it will be complete by end of the month, and don't think there will be too many changes. I can keep the issue open to migrate the URI tov1
(removing thedraft
) with whatever remaining format changes there are in the follow-up.Please verify and check that the pull request fulfills the following
requirements: