Changes to vuln 0.1 spec and documentation #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Lum <[email protected]>
|
@hectorj2f can you validate if any of the suggested changes here would reflect in #345 as well? fyi, i don't have maintainer bit here, so no control over that :) |
hectorj2f
reviewed
Oct 13, 2024
| @@ -64,41 +64,39 @@ The `predicate` contains a JSON-encoded data with the following fields: | |||
|
|
|||
| > > > The version of the Vulnerability DB. | |||
|
|
|||
| **scanner.db.lastUpdate, required** string (timestamp) | |||
| **scanner.db.lastUpdate, optional** string (timestamp) | |||
There was a problem hiding this comment.
I won't change this setting. It is important to reflect the update of the database used for the scanner.
hectorj2f
reviewed
Oct 13, 2024
| > > > > > This is a list of key/value pairs where scanners can add additional custom information. | ||
|
|
||
| **metadata.scanStartedOn, required** Timestamp | ||
| **metadata.scanStartedOn, optional** Timestamp |
There was a problem hiding this comment.
I have the same thoughts as above. This must be required to ensure all the details and reuse these attestations in the future.
hectorj2f
reviewed
Oct 13, 2024
|
|
||
| > > > The vulnerability object defines information about each one of the vulnerabilities found by the scanner. | ||
| **scanner.result.[*].id, required** string |
There was a problem hiding this comment.
These changes look good to me, we can remove the vulnerability, and assume they refer to vulnerabilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #391 and #390, and making several changes which help with implementing the spec. Comments welcome! Am happy to split up the changes if some of them may be potentially controversial. Tagging original author: @hectorj2f
#390
#391
from the spec since it is the only field within it (as reflected in
the example).
the example).
Make several fields which may not always be available optional.
available.
may not always be available when a DB uri/version is known.