-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add predicate specification for CycloneDX #129
Conversation
Sorry about that, for some reason I though it was in that format. I'll take a look at this next week and update 👍 |
I'm afraid I don't know the answer to this question as I have very little practical experience with CycloneDX. Hopefully others can chime in that do have experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be good to go. It does reference the most up-to-date CDX schema as the predicate
spec/predicates/cyclonedx.md
Outdated
"subject": [{ ... }], | ||
|
||
// Predicate: | ||
"predicateType": "https://cyclonedx.org/BOM", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it supposed to just be https://cyclonedx.org/bom
? The page doesn't include the version (which I assume is embedded in the predicate
field as it is for SPDX?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @danbev ! I have a few more change suggestions for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes, @danbev !
One more thing: Could you please add a link to the CycloneDX spec in the predicates list?
This commit adds a predicate specification for CycloneDX using the example specification from issue in-toto#82. The motivation for doing this is only to offer help with getting this into in-toto, in case the original author currently does not have time. Co-authored-by: samj1912 <[email protected]> Resolves: in-toto#82 Signed-off-by: Daniel Bevenius <[email protected]>
Update list of vetted predicates. Signed-off-by: Daniel Bevenius <[email protected]>
91382c3
to
cc2737a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, generally looks good, just a couple small comments.
Add link to README.md and remove tentative. Signed-off-by: Daniel Bevenius <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the changes
This commit adds a predicate specification for CycloneDX using the example specification from issue #82.
The motivation for doing this is only to offer help with getting this into in-toto, in case the original author currently does not have time.
Co-authored-by: samj1912 [email protected]
Resolves: #82
Signed-off-by: Daniel Bevenius [email protected]