-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update readme and remove chart dir #447
Conversation
- helm charts moved to github.com/in-toto/helm-charts - see in-toto/community#34 Signed-off-by: Will <[email protected]>
@kairoaraujo I think that https://github.com/in-toto/helm-charts is at a good enough spot to merge this. Does that sound right? |
I'm double checking it. |
@@ -210,7 +210,7 @@ timestamp { | |||
## Deployment | |||
|
|||
Archivista can be easily deployed thru the provided helm chart into your | |||
kubernetes cluster. See the [README](chart/README.md) for more details. | |||
kubernetes cluster. See the [README](https://github.com/in-toto/helm-charts/blob/main/charts/archivista/README.md) for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Should we point it to http://in-toto.github.io/helm-charts/ or Archivista specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this "future proofed" for if or when we add additional charts to the repo?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
==========================================
- Coverage 82.40% 1.71% -80.69%
==========================================
Files 10 123 +113
Lines 358 33440 +33082
==========================================
+ Hits 295 573 +278
- Misses 43 32809 +32766
- Partials 20 58 +38 ☔ View full report in Codecov by Sentry. |
What this PR does / why we need it
Which issue(s) this PR fixes (optional)
Acceptance Criteria Met
Special notes for your reviewer: