Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update readme and remove chart dir #447

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

wcrum
Copy link
Contributor

@wcrum wcrum commented Dec 16, 2024

What this PR does / why we need it

  • Outdated helm charts within this repository.

Which issue(s) this PR fixes (optional)

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

- helm charts moved to github.com/in-toto/helm-charts
- see in-toto/community#34

Signed-off-by: Will <[email protected]>
@jkjell
Copy link
Member

jkjell commented Dec 17, 2024

@kairoaraujo I think that https://github.com/in-toto/helm-charts is at a good enough spot to merge this. Does that sound right?

@kairoaraujo
Copy link
Collaborator

@kairoaraujo I think that https://github.com/in-toto/helm-charts is at a good enough spot to merge this. Does that sound right?

I'm double checking it.

@@ -210,7 +210,7 @@ timestamp {
## Deployment

Archivista can be easily deployed thru the provided helm chart into your
kubernetes cluster. See the [README](chart/README.md) for more details.
kubernetes cluster. See the [README](https://github.com/in-toto/helm-charts/blob/main/charts/archivista/README.md) for more details.
Copy link
Collaborator

@kairoaraujo kairoaraujo Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Should we point it to http://in-toto.github.io/helm-charts/ or Archivista specific?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this "future proofed" for if or when we add additional charts to the repo?

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.71%. Comparing base (a035c62) to head (9840595).
Report is 231 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #447       +/-   ##
==========================================
- Coverage   82.40%   1.71%   -80.69%     
==========================================
  Files          10     123      +113     
  Lines         358   33440    +33082     
==========================================
+ Hits          295     573      +278     
- Misses         43   32809    +32766     
- Partials       20      58       +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kairoaraujo kairoaraujo merged commit 775e9e1 into in-toto:main Dec 17, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants