Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITE-10: Support contextual predicates in layouts #49

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

adityasaky
Copy link
Member

@adityasaky adityasaky commented May 25, 2023

This was previously part of #38. I've broken that one down into separate ITEs so it's easier to reason about the changes proposed.

Prototyping here: https://github.com/adityasaky/in-toto-attestation-verifier

@mikhailswift
Copy link
Member

I like the distinction of 'transformational' and 'informational' predicates. I think that succinctly captures a lot of what we learned with Witness and the distinctions we found between our attestors. I think this ITE is looking good.

ITE/10/README.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@TomHennen TomHennen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes total sense to me!

ITE/10/README.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adityasaky !

ITE/10/README.adoc Outdated Show resolved Hide resolved
ITE/10/README.adoc Outdated Show resolved Hide resolved
ITE/10/README.adoc Outdated Show resolved Hide resolved
ITE/10/README.adoc Outdated Show resolved Hide resolved
ITE/10/README.adoc Outdated Show resolved Hide resolved
ITE/10/README.adoc Outdated Show resolved Hide resolved
Copy link
Member

@SantiagoTorres SantiagoTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, and I'm happy to merge this as draft. I'd still want to explore the security position of sublayouts a bit more on a future iteration (e.g,. when marking as active).

ITE/10/README.adoc Outdated Show resolved Hide resolved
ITE/10/README.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @adityasaky . I have a few clarifying comments but really like where this ITE is going.

ITE/10/README.adoc Outdated Show resolved Hide resolved
ITE/10/README.adoc Outdated Show resolved Hide resolved
ITE/10/README.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some more comments to my review.

ITE/10/README.adoc Outdated Show resolved Hide resolved
ITE/10/README.adoc Show resolved Hide resolved
ITE/10/README.adoc Outdated Show resolved Hide resolved
ITE/10/README.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all your work on this @adityasaky !

@SantiagoTorres SantiagoTorres merged commit a610188 into in-toto:master Aug 4, 2023
@adityasaky adityasaky deleted the ite-10 branch August 4, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants