-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ITE-10: Support contextual predicates in layouts #49
Conversation
I like the distinction of 'transformational' and 'informational' predicates. I think that succinctly captures a lot of what we learned with Witness and the distinctions we found between our attestors. I think this ITE is looking good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes total sense to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adityasaky !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, and I'm happy to merge this as draft. I'd still want to explore the security position of sublayouts a bit more on a future iteration (e.g,. when marking as active).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @adityasaky . I have a few clarifying comments but really like where this ITE is going.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some more comments to my review.
Signed-off-by: Aditya Sirish <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all your work on this @adityasaky !
This was previously part of #38. I've broken that one down into separate ITEs so it's easier to reason about the changes proposed.
Prototyping here: https://github.com/adityasaky/in-toto-attestation-verifier