-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Listen on all interfaces #23
Listen on all interfaces #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ebroto - really great work as usual! Just a couple of minor issues and I'd be excited to go forward and merge this.
Also, forgot to mention, the timeout increase works great for me too and I'm very happy about the CPU performance - so thanks, let's go with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, just one more thing with the break syntax and we're good to go with this.
Specifying an interface is now optional. The interface is shown in the connections table.
13fd853
to
6436b7d
Compare
Got caught by clippy in the CI, happy that it works :) On it |
Cool - so I think this is good to merge once the tests pass. Definitely good to know the new CI stuff is working. :) Feel free to merge, I'll publish to the various outlets over the weekend (at some point I'll have to automate this). |
Hey @ebroto - I'm in the process of releasing |
Thanks!! I appreciate the intention but I'm not on twitter. I usually read the subreddit but mainly lurking, so a mention would be more than enough :) |
The parameter "-i" is now optional and we listen on all interfaces by default.
The interface is shown in the connections table.
I've changed the read timeout for the datalink channel from 1 ns to 2 ms because I realized (before the changes) that we were using quite some CPU there. In my computer it went from taking consistently over 10% of one CPU to ~2%. I think it should be enough to handle the traffic and to keep the application responsive to the "quit" key. Let me know if you find it appropriate!
Closes #16