ISSUE-100: Add lazy loading of modules #132
Conversation
| @@ -28,7 +28,7 @@ | |||
| "hammerjs": "2.0.8", | |||
| "moment": "2.17.1", | |||
| "rxjs": "5.1.0", | |||
| "zone.js": "0.8.4" | |||
| "zone.js": "0.8.5" | |||
There was a problem hiding this comment.
We were apparently using an old version of this.. 👎
There was a problem hiding this comment.
Always pretty cool bumping deps, but was this why things were breaking?
There was a problem hiding this comment.
This is about all that I can give you. angular/angular#15185 I believe it has to do with their approach to overriding the global Error object - https://github.com/angular/zone.js/blob/v0.8.5/CHANGELOG.md
| ], | ||
| providers: [ | ||
| ExtHttp, | ||
| IdentityService, | ||
| LocalStorage, | ||
| LoginService, | ||
| ResponseHandler, | ||
| AuthGuard, | ||
| ProjectService, |
There was a problem hiding this comment.
ProjectService is used outside of the project module.
| @@ -13,9 +13,8 @@ import { | |||
| } from '../core'; | |||
|
|
|||
| @Component({ | |||
| selector: 'at-login', | |||
There was a problem hiding this comment.
I removed a bunch of selectors that don't do anything. They're routed directly via routers.
| @@ -8,9 +8,6 @@ body { | |||
| } | |||
|
|
|||
| .main-container { | |||
| margin-left: auto; | |||
| margin-right: auto; | |||
| max-width: 1024px; | |||
There was a problem hiding this comment.
This ended up looking pretty weird with navigation. I'm comfortable saying that we're targeting mobile devices due to our adoption of material.
| CoreModule.forRoot(extHttpConfig), | ||
| EmployeeModule, | ||
| ProjectModule, | ||
| TimesheetModule, |
There was a problem hiding this comment.
I basically just gave up on this for now and included the timesheet module eagerly.
| import { NgModule, CUSTOM_ELEMENTS_SCHEMA } from '@angular/core'; | ||
| import { HttpModule } from '@angular/http'; | ||
| import { FormsModule } from '@angular/forms'; | ||
| import { NgModule } from '@angular/core'; |
There was a problem hiding this comment.
I was wondering what that CUSTOM_ELEMENTS_SCHEMA was even doing. I think that's for Polymer elements or something :/
There was a problem hiding this comment.
Yeah, i'm looking at cleaning that up as well. This has to do with how we're including the angular material modules. If we include them correctly, we'll get rid of these errors.
| import { IdentityService } from './identity.service'; | ||
| import { LocalStorage } from './localStorage'; | ||
| import { LoginService } from './login.service'; | ||
| import { ResponseHandler } from './responseHandler.service'; | ||
| import { ExtHttp } from './extHttp.service'; | ||
| import { ExtHttpConfig } from './ExtHttpConfig'; | ||
| import { AuthGuard } from './auth-guard.service'; |
Add lazy loading for modules with the exception of timesheet due to an unresolved issue. Upgrade zone.js to fix weird testing messages. Also ad sidenav.
Add lazy loading for modules with the exception of timesheet due to an unresolved issue. Upgrade zone.js to fix weird testing messages. Also ad sidenav.
Resolves #100.
Resolves #124.