Add compatibility with rules_typescript #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally we should generate different JS content for devmode "es5" vs prodmode "es6" so that bundlers can do the best job on them, like we do in |
|
@alexeagle, @Globegitter what is the status of this change? Is it still in progress or should it be landed? |
|
Seems like this can be closed in favour of #138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was taken from: https://github.com/bazelbuild/rules_typescript/blob/d25f3ce7438d8fb3497115f04a029232c8ef2861/internal/protobufjs/ts_proto_library.bzl#L93 and adapted for this rule
Edit: Just to clarify this was necessary for me to get grpc-web work with rules_typescript.