Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ts-protoc-gen-library rule to generate protos using Bazel #77

Closed
easyCZ opened this issue May 27, 2018 · 3 comments
Closed

Add ts-protoc-gen-library rule to generate protos using Bazel #77

easyCZ opened this issue May 27, 2018 · 3 comments

Comments

@easyCZ
Copy link
Contributor

easyCZ commented May 27, 2018

In order to improve support for Bazel, we should introduce a rule to allow generation of TS protos idiomatically with Bazel.

The benefits

  1. Ability to synchronise generated code for multiple targets
  2. Native experience for Bazel users
  3. Contribution to the ecosystem of Bazel

How

A ts_proto_library already exists (docs) leverages Protobuf.JS. We can utilize the learnings from there to add a similar rule.
The code should be contributed to rules_typescript for uniformity but we should test against the rule ourselves on our CI.

Notes

Initial research of this shows this should be very doable and can provide better integration with Bazel than Protobuf.JS as we can choose to compile individual protos based on the dependency analysis from Bazel.

If you have a use case for ts-protoc-gen and Bazel, please let us know so we can better cater for it.

@easyCZ easyCZ self-assigned this May 27, 2018
@easyCZ
Copy link
Contributor Author

easyCZ commented May 27, 2018

@coltonmorris
Copy link
Contributor

I've opened a pull request in this repo with the rule here.

@stale
Copy link

stale bot commented Aug 28, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 28, 2018
@stale stale bot closed this as completed Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants