Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Bazel #197

Open
igorgatis opened this issue May 27, 2018 · 4 comments
Open

Support for Bazel #197

igorgatis opened this issue May 27, 2018 · 4 comments
Labels

Comments

@igorgatis
Copy link

It would be great to have rules for Bazel, specially if they work with https://github.com/bazelbuild/rules_typescript

@easyCZ
Copy link
Contributor

easyCZ commented May 27, 2018

Hey @igorgatis,

Indeed. Currently working on improbable-eng/ts-protoc-gen#77. Once we have that, grpc-web is the natural next step.

Having said that, your help would be greatly appreciated. If you've got experience with Bazel or want to dig in, please do. We can use this channel to figure out the details.

@easyCZ easyCZ added enhancement help-wanted We'd like your help! labels May 27, 2018
@mikelnrd
Copy link

Hey @easyCZ. Just came across this issue looking for bazel support for grpc-web.

Just FYI I noticed that this pull request improbable-eng/ts-protoc-gen#84 has been merged and so the ts-protoc-gen bazel rule is I think complete but issue improbable-eng/ts-protoc-gen#77 hasn't been closed yet.

Thought I'd just flag it here as you're waiting for improbable-eng/ts-protoc-gen#77 to move forward with bazel support for grpc-web - which I selfishly want :)

@coltonmorris
Copy link

coltonmorris commented Jun 22, 2018

Isn't there already bazel support? It would be nice if rules-typescript allowed ts code to import the files generated by ts-protoc-gen in a cleaner way rather than having to reference gen files or use path aliases. But it's still supported and works.

Maybe I'm missing something? ¯\_(ツ)_/¯

@johanbrandhorst
Copy link
Contributor

Do we need both Bazel support and go.mod support? Can Bazel accommodate go mod files? See #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants