Export a CommonJS and UMD Module #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcusLongmuir - It looks like the travis run failed because the browser stack key is invalid. |
Dig-Doug
changed the title
|
Friendly ping on this. @jonnyreeves - Is this something you can review? |
…. Also refactors the js version of iterateHeaders to typescript.
|
Rebased. Thanks for taking a look! |
jonny-improbable
approved these changes
Nov 15, 2018
|
@jonnyreeves - Can you publish a new version of browser-headers on npm with this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a rollup config that builds the library in multiple formats. Each build format is listed in the package.json so tools can leverage them.
Also updates the iterateHeaders code to be in TS and fixes a few lint errors.
Update to the original description
Based on the feedback I got for grpc-web, I've updated this PR to use webpack to generate the UMD module.