Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove connection header from grpcwebproxy #588

Merged

Conversation

crlssn
Copy link
Contributor

@crlssn crlssn commented Oct 28, 2019

This PR fixes the issue expressed in #568. Basically, when you are sending a gRPC request from a web client through the proxy, multiple headers are added of which connection is denying the actual connection to be established.

Error message with the connection header present:

INFO[0000] listening for http on: [::]:8080             
INFO[0000] pickfirstBalancer: HandleSubConnStateChange: 0xc00015e200, READY  system=system
INFO[0075] transport: loopyWriter.run returning. connection error: desc = "transport is closing"  system=system
INFO[0075] pickfirstBalancer: HandleSubConnStateChange: 0xc00015e200, TRANSIENT_FAILURE  system=system
INFO[0075] pickfirstBalancer: HandleSubConnStateChange: 0xc00015e200, CONNECTING  system=system
WARN[0075] finished streaming call with code Unavailable  error="rpc error: code = Unavailable desc = transport is closing" grpc.code=Unavailable grpc.method=Method grpc.service=namespace.Service grpc.start_time="2019-10-28T11:56:35Z" grpc.time_ms=1052.424 span.kind=server system=grpc

@johanbrandhorst
Copy link
Contributor

Now we begin the delicate dance of making the CI pass...

@johanbrandhorst johanbrandhorst merged commit 99d9185 into improbable-eng:master Oct 28, 2019
@johanbrandhorst
Copy link
Contributor

Thanks for the fix @crlssn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants