Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: sanitize migration param url #7634

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix: sanitize migration param url #7634

merged 2 commits into from
Dec 3, 2024

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Nov 27, 2024 •
edited
Loading

Resolves GIVE-2042

Description

This adds sanitization to the migration url param in the admin.

Affects

The manual migration url

Visuals

N/A

Testing Instructions

TBD

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein force-pushed the fix/sanitize-migration-url branch from 256e8b2 to 20921c1 Compare November 27, 2024 21:30
@jonwaldstein jonwaldstein marked this pull request as ready for review December 2, 2024 20:20
@kjohnson kjohnson self-requested a review December 2, 2024 20:26
rickalday
rickalday approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@jonwaldstein jonwaldstein merged commit 4fb99af into develop Dec 3, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/sanitize-migration-url branch December 3, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjohnson kjohnson kjohnson approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonwaldstein @rickalday @kjohnson