Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Update goal progress with campaign entity #7628

Merged
merged 8 commits into from
Nov 21, 2024
Merged

Refactor: Update goal progress with campaign entity #7628

merged 8 commits into from
Nov 21, 2024

Conversation

kjohnson
Copy link
Member

@kjohnson kjohnson commented Nov 20, 2024 •
edited
Loading

Description

This PR updates the Goal Progress widget on the Campaign Overview tab to use the Campaign entity.

Affects

  • Adds a useCampaign() hook to wrap useEntityRecord().
  • Updates CampaignRequestController::getCampaign() to return the goalProgress.

Visuals

image

Testing Instructions

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@kjohnson kjohnson marked this pull request as ready for review November 20, 2024 20:32
@kjohnson kjohnson requested review from JasonTheAdams and glaubersilva and removed request for glaubersilva November 21, 2024 18:33
JasonTheAdams
JasonTheAdams approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@JasonTheAdams JasonTheAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @kjohnson ! Left two minor suggestion. Love the custom entity hook! Given how simple the suggestions are I'll go ahead and approve this.

src/Campaigns/Routes/RegisterCampaignRoutes.php Show resolved Hide resolved
src/Campaigns/resources/admin/components/CampaignDetailsPage/useCampaign.tsx Outdated Show resolved Hide resolved
@kjohnson kjohnson merged commit 4bc0ecf into epic/campaigns Nov 21, 2024
20 checks passed
@kjohnson kjohnson deleted the refactor/campaign-goal-progress-data branch November 21, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonTheAdams JasonTheAdams JasonTheAdams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjohnson @JasonTheAdams