Update campaign design implementation #7613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjohnson
changed the title
…om:impress-org/give into refactor/campaigns-design-review-GIVE-1343
|
Build for QA, see https://github.com/impress-org/givewp/actions/runs/11730025603. |
glaubersilva
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
@kjohnson Looks good to me. I agree it would be best to do the design review in the final zip so we can merge it and have a deliverable quicker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-1343
Description
This PR makes a number of design related changes to the Campaign domain.
Note: This will mostly require design review, which I think we can do as a part of the upcoming zip.