Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add merge campaigns UI #7612

Merged
merged 27 commits into from
Nov 8, 2024
Merged

Feature: add merge campaigns UI #7612

merged 27 commits into from
Nov 8, 2024

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Nov 7, 2024 •
edited
Loading

Resolves GIVE-1402 GIVE-1405

Description

This PR adds the merge campaign UI to the campaigns list table so donors can merge two or more campaigns into a destination campaign.

Affects

The campaigns list table.

Visuals

https://www.loom.com/share/1094188511c342c2a3df996cf70c60e9?sid=d5822974-9a01-463f-85bd-a2114a8bce9e

Testing Instructions

  1. Go to the Campaigns list table;
  2. Select two or more campaigns;
  3. Choose Merge in the bulk actions;
  4. Follow the steps to merge the campaigns.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Nov 7, 2024
@glaubersilva glaubersilva changed the base branch from epic/campaigns to feature/list-view-change-default-form-GIVE-1333 November 7, 2024 01:41
@glaubersilva glaubersilva changed the base branch from feature/list-view-change-default-form-GIVE-1333 to epic/campaigns November 7, 2024 01:42
@glaubersilva glaubersilva changed the base branch from epic/campaigns to feature/list-view-change-default-form-GIVE-1333 November 7, 2024 01:43
@glaubersilva glaubersilva marked this pull request as ready for review November 7, 2024 22:06
alaca
alaca requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Glauber, there are a few things that should be addressed, but overall, good job man.

src/Campaigns/resources/admin/components/MergeCampaign/Form/index.tsx Outdated Show resolved Hide resolved
src/Campaigns/resources/admin/components/MergeCampaign/Form/index.tsx Outdated Show resolved Hide resolved
src/Campaigns/resources/admin/components/MergeCampaign/Form/index.tsx Show resolved Hide resolved
src/Campaigns/resources/admin/components/MergeCampaign/Form/index.tsx Show resolved Hide resolved
src/Views/Components/ListTable/ListTablePage/index.tsx Outdated Show resolved Hide resolved
src/Views/Components/ListTable/ListTablePage/index.tsx Show resolved Hide resolved
src/Campaigns/resources/admin/components/MergeCampaign/Modal/index.tsx Show resolved Hide resolved
Base automatically changed from feature/list-view-change-default-form-GIVE-1333 to epic/campaigns November 8, 2024 14:58
alaca
alaca approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@glaubersilva glaubersilva merged commit 462bd8c into epic/campaigns Nov 8, 2024
20 checks passed
@glaubersilva glaubersilva deleted the feature/merge-capmpaign-UI-GIVE-1402-GIVE-1405 branch November 8, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaca alaca alaca approved these changes

@kjohnson kjohnson Awaiting requested review from kjohnson

Assignees

@glaubersilva glaubersilva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glaubersilva @alaca