Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: goal creation modal should not highlight previous button #7611

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Fix: goal creation modal should not highlight previous button #7611

merged 3 commits into from
Nov 7, 2024

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Nov 6, 2024 •
edited
Loading

Resolves GIVE-1340

Description

This PR implements a few CSS tweaks to make the "previous" button from the Create Campaign modal match the design.

Affects

The creation of new campaigns.

Visuals

Demo video: https://www.loom.com/share/175097c6f0e142388f37afcf23a904e6?sid=a3c9ec94-56ba-41f0-9561-2a9ec5040325

image

Testing Instructions

  1. On the campaigns page click on the "Create Campaign" button;
  2. Go to the second step of the form and make sure the "previous" button looks like on design.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Nov 6, 2024
@glaubersilva glaubersilva marked this pull request as ready for review November 6, 2024 18:59
alaca
alaca approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@glaubersilva glaubersilva merged commit cef7414 into epic/campaigns Nov 7, 2024
20 checks passed
@glaubersilva glaubersilva deleted the fix/modal-previous-button-GIVE-1340 branch November 7, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaca alaca alaca approved these changes

@kjohnson kjohnson Awaiting requested review from kjohnson

@jdghinson jdghinson Awaiting requested review from jdghinson

Assignees

@glaubersilva glaubersilva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glaubersilva @alaca