Fix: Prevent page refresh when opening the Create Campaign Modal #7608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjohnson
commented
Nov 6, 2024
|
Build for QA, see https://github.com/impress-org/givewp/actions/runs/11728970917. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-1342
Description
This PR prevents a page refresh when clicking the Create Campaign button in the Campaign List Table.
Affects
The state for the Create Campaign Modal has been lifted to the
<CampaignsListTable />parent component so that it can be shared by the<ListTableBlankSlate />and the<CreateCampaignModal />components.Visuals
Testing Instructions
With no campaigns created, from the campaign list table click the "create campaign" button within the table's empty state (as opposed to the header).
Pre-review Checklist
@unreleasedtags included in DocBlocks