Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update sidebar style for WordPress 6.7 compatibility #7603

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Nov 4, 2024

Resolves GIVE-1509

Description

WordPress 6.7 introduced some new css classnames to the sidebar we are using that are causing styling issues:

  • block-editor-tabbed-sidebar__tablist-and-close-button
  • .block-editor-tabbed-sidebar

This PR adds some specific css tweaks to these classes to prevent:

  1. The sidebar tabs from showing (Blocks, Patterns, Media tab)
  2. The sidebar width becoming fixed with a scrollbar

Affects

The from builder sidebar on WordPress 6.7

Visuals

Before

wp-6.7.mov

After

Screenshot 2024-11-04 at 12 50 23 PM

Testing Instructions

  • Install WP 6.7-RC
  • Make sure the form builder sidebar works as expected

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the title Fix: Update sidebar style for WordPress 6.7 compatability Fix: Update sidebar style for WordPress 6.7 compatibility Nov 4, 2024
@jonwaldstein jonwaldstein marked this pull request as ready for review November 4, 2024 17:51
@JasonTheAdams
Copy link
Contributor

Great job catching this, @jonwaldstein! 💪

@JoshuaHungDinh
Copy link
Contributor

Looks good 👍

testing.mov

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@jonwaldstein jonwaldstein changed the base branch from develop to release/3.17.2 November 5, 2024 17:02
@jonwaldstein jonwaldstein merged commit 4517963 into release/3.17.2 Nov 5, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/wp-6.7-style branch November 5, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants