Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Check for campaign goal before calculating percentage #7596

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Fix: Check for campaign goal before calculating percentage #7596

merged 4 commits into from
Nov 4, 2024

Conversation

kjohnson
Copy link
Member

@kjohnson kjohnson commented Oct 29, 2024 •
edited
Loading

Resolves GIVE-1428

Description

This PR checks for a campaign goal before calculating a goal progress as a percentage, which might attempt to divide by zero.

Testing Instructions

  • Create a campaign
  • Set the campaign goal to zero
  • Load the Campaign List Table

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@kjohnson kjohnson changed the base branch from develop to epic/campaigns October 29, 2024 18:09
@kjohnson kjohnson marked this pull request as ready for review October 29, 2024 18:12
@kjohnson
Copy link
Member Author

Build for QA, see https://github.com/impress-org/givewp/actions/runs/11579967891.

glaubersilva
glaubersilva approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I just left a couple of comments related to minor things. But I'll approve it to advance the things.

tests/Unit/Campaigns/DataTransferObjects/CampaignGoalDataTest.php Show resolved Hide resolved
tests/Unit/Campaigns/DataTransferObjects/CampaignGoalDataTest.php Outdated Show resolved Hide resolved
alaca
alaca approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rickalday
rickalday approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests

@kjohnson kjohnson merged commit 18d4c4c into epic/campaigns Nov 4, 2024
18 checks passed
@kjohnson kjohnson deleted the fix/campaign-goal-data-divide-by-zero-GIVE-1428 branch November 4, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaubersilva glaubersilva glaubersilva approved these changes

@alaca alaca alaca approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjohnson @rickalday @alaca @glaubersilva