Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Associate upgraded form to a campaign #7592

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

alaca
Copy link
Member

@alaca alaca commented Oct 29, 2024

Description

This PR updates the form migration process by associating the upgraded form with a campaign.

Affects

Form migration

Visuals

Screen.Recording.2024-10-29.at.09.23.54.mov

Testing Instructions

In Campaign context:

  • Create a V2 form
  • Upgrade the V2 form

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@alaca alaca requested a review from kjohnson October 29, 2024 08:27
Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alaca can you add a test for this?

It might help to extract the Campaign Form logic to an Action Class and then add a test for the Action.

src/FormMigration/Controllers/MigrationController.php Outdated Show resolved Hide resolved
src/FormMigration/Controllers/MigrationController.php Outdated Show resolved Hide resolved
@alaca alaca merged commit 937c430 into epic/campaigns Nov 6, 2024
20 checks passed
@alaca alaca deleted the feature/update-upgrade-process-GIVE-1346 branch November 6, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants