-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: prevent serialized data by default #7583
Merged
glaubersilva
merged 14 commits into
develop
from
enhancement/give-clean-unserialize-GIVE-1294
Oct 31, 2024
Merged
Enhancement: prevent serialized data by default #7583
glaubersilva
merged 14 commits into
develop
from
enhancement/give-clean-unserialize-GIVE-1294
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
glaubersilva
changed the title
Enhancement: Enhancement: prevent serialize data by default
Enhancement: prevent serialize data by default
Oct 25, 2024
glaubersilva
changed the title
Enhancement: prevent serialize data by default
Enhancement: prevent serialized data by default
Oct 25, 2024
jonwaldstein
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glaubersilva awesome job, thanks for doing this! (just added a few notes)
rickalday
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-1294
Description
This PR implements a few improvements and unit tests for our Utils functions related to serialized data.
This PR also changes the
give_clean()
function to unserialize all data input by default, but it is possible to allow serialized data by setting the$allow_serialized_data
to true.Last, but not least important, this PR also adds a new migration to unserialize data from the
_give_donor_billing_title_prefix
donation meta value.Affects
As many places are using the
give_clean()
method, these changes affect the entire codebase, but especially the submission of new donations for v2 forms.Testing Instructions
composer test -- --filter UtilsTest
command in your terminal.Pre-review Checklist
@unreleased
tags included in DocBlocks