Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: adjust Subscription Manager styles for custom amount #7579

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

Description

This PR addresses style changes that were made in the Subscription Manager page of the Donor Dashboard. By allowing the Select amount dropdown to expand full width when alone, but also split the FieldRow when the custom amount option is available.

Affects

Donor Dashboard Subscriptions

Visuals

Screenshot 2024-10-21 at 4 46 18 PM
Screenshot 2024-10-21 at 4 39 34 PM

Testing Instructions

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein self-requested a review October 22, 2024 13:47
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshuaHungDinh thanks! ready for QA 🌈

@jonwaldstein jonwaldstein force-pushed the fix/update-custom-amount-styles branch from 6816c74 to 3fdb460 Compare October 22, 2024 13:49
@jonwaldstein jonwaldstein changed the base branch from develop to release/3.17.1 October 22, 2024 13:49
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@jonwaldstein jonwaldstein merged commit 7d96b45 into release/3.17.1 Oct 22, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/update-custom-amount-styles branch October 22, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants