Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add campaign goal types for recurring donations #7567

Merged
merged 9 commits into from
Oct 14, 2024
Merged

Feature: add campaign goal types for recurring donations #7567

merged 9 commits into from
Oct 14, 2024

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Oct 9, 2024 •
edited
Loading

Resolves GIVE-1265

Description

This PR add three new goal types related to recurring donations.

Affects

New campaign creating and editing (settings tab)

Visuals

image

Testing Instructions

Create and edit new campaigns using 3 new options for recurring donations.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Oct 9, 2024
@glaubersilva glaubersilva marked this pull request as ready for review October 9, 2024 20:14
alaca
alaca reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, man! Good job. I have only one thing that should be addressed - showing recurring fields only if the recurring add-on is installed. Other than that, this is good to go.

src/Campaigns/resources/admin/components/CampaignDetailsPage/Tabs/Settings.tsx Outdated Show resolved Hide resolved
src/Campaigns/resources/admin/components/CampaignFormModal/index.tsx Outdated Show resolved Hide resolved
@glaubersilva
Copy link
Contributor Author

@alaca Nice catch about the recurring add-on, thanks! This is ready for re-review.

alaca
alaca reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey man, much better.
Just put everything in one condition and this is good to go.

src/Campaigns/resources/admin/components/CampaignDetailsPage/Tabs/Settings.tsx Show resolved Hide resolved
src/Campaigns/resources/admin/components/CampaignFormModal/index.tsx Show resolved Hide resolved
@glaubersilva
Copy link
Contributor Author

@alaca Thanks, man! Everything is in one condition now.

alaca
alaca approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's much cleaner now. Thanks, man. Good job 👍

@glaubersilva glaubersilva merged commit 520f2a3 into epic/campaigns Oct 14, 2024
20 checks passed
@glaubersilva glaubersilva deleted the feature/goals-recurring-donations-GIVE-1265 branch October 14, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaca alaca alaca approved these changes

Assignees

@glaubersilva glaubersilva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glaubersilva @alaca