Feature: Archive campaigns #7565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns-GIVE-1262 # Conflicts: # src/Campaigns/resources/admin/components/CampaignDetailsPage/CampaignDetailsPage.module.scss # src/Campaigns/resources/admin/components/CampaignDetailsPage/index.tsx
glaubersilva
requested changes
Oct 10, 2024
There was a problem hiding this comment.
@alaca This looks great man, good job! I just left a few comments related to the naming and styles for status. I would like to use the same pattern used in the campaigns list table which already was approved by Jeffrey previously.
src/Campaigns/resources/admin/components/CampaignDetailsPage/index.tsx
Outdated
Show resolved
Hide resolved
src/Campaigns/resources/admin/components/CampaignDetailsPage/CampaignDetailsPage.module.scss
Outdated
Show resolved
Hide resolved
glaubersilva
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
@alaca Thanks for the changes. It looks better now. I just left a comment asking to remove an unused CSS class but I will approve it right now just to advance things. So please remember to remove it before merge, great work!
src/Campaigns/resources/admin/components/CampaignDetailsPage/CampaignDetailsPage.module.scss
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds archive functionality to campaigns. Also, a new store for notifications has been added.
Visuals
Testing Instructions
Pre-review Checklist
@unreleasedtags included in DocBlocks