Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: refine subscription management UI/UX #7557

Merged
merged 34 commits into from
Oct 7, 2024
Merged

Feature: refine subscription management UI/UX #7557

merged 34 commits into from
Oct 7, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Sep 30, 2024 •
edited
Loading

Resolves: GIVE-1267

Description

This PR updates the design and cancel workflow of the subscription management page within the DonorDashboard.
With these changes eligible subscriptions will now be canceled from the manage subscription page. We have updated the UI of the page and the SubscriptionCloseModal Non eligible subscriptions can still be cancelled from the subscription list rows as previously done.

Affects

  • Subscription rows

Visuals

Screen.Recording.2024-10-07.at.12.44.32.PM.mov

Testing Instructions

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh
refactor: update Button component to typescript to handle optional props
88a1da8
@JoshuaHungDinh
refactor: update cancel modal content ui with new button placement & …
ae9fd0f 
…typescript
@JoshuaHungDinh
refactor: update subscriptionmanagement page to typescript. extract p…
0960512 
…ause functions into hook diectory
@JoshuaHungDinh
fix: update pauseDuration type
aa421fd
@JoshuaHungDinh
chore: removed in favaor of new directory name
39f2130
@JoshuaHungDinh
refactor: update to typescript. introduce pausing while attempting to…
d8683fb 
… cancelsubscription
@JoshuaHungDinh
feature: include cancelmodal in pausedropdown styles
0a9e570
@JoshuaHungDinh
refactor: update subscription cancel props
834602d
@JoshuaHungDinh
refactor: check for active subscriptions when determining to render p…
215a3d4 
…ause functionallity
@JoshuaHungDinh
refactor: update buttons and placement
9eb88ac
@JoshuaHungDinh
refactor: handle modal content on close
06ed1c8
@JoshuaHungDinh JoshuaHungDinh changed the title Feature: enable pausing subscriptions from cancel modal Feature: add pause subscription option to cancel modal Sep 30, 2024
@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review September 30, 2024 17:08
@JoshuaHungDinh JoshuaHungDinh changed the title Feature: add pause subscription option to cancel modal Feature: refine subscription management UI/UX Oct 2, 2024
pauloiankoski
pauloiankoski approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s a lot in this PR, but I didn’t see anything that stood out as strongly wrong. It mainly seems like what I saw before the design review. So, I’m approving it.

@JoshuaHungDinh JoshuaHungDinh merged commit 50f58cd into epic/stripe-subscription-management Oct 7, 2024
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the feature/add-pause-to-cancle-modal branch October 7, 2024 21:34
@JoshuaHungDinh JoshuaHungDinh mentioned this pull request Oct 7, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauloiankoski pauloiankoski pauloiankoski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaHungDinh @pauloiankoski