Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: move recipient email above general settings filter #7554

Conversation

JoshuaHungDinh
Copy link
Contributor

Description

The Stripe recipient email setting is placed after the filter that designates the end of the [General] settings. This causes any new settings introduced by the filter give_stripe_add_after_general_fields to be placed prior to this setting. The filter should be placed below the last default setting so that additional settings introduced are inserted at the bottom.

Affects

Stripe Settings

Visuals

Screenshot 2024-09-26 at 12 27 47 PM

Testing Instructions

  • Donations->Settings->Paymentgateways->Stripe : Verify the new admin setting for pausing subscriptions is inserted at the bottom. This will require the latest version of Stripe in order for the new setting to be displayed.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the base branch from develop to epic/stripe-subscription-management September 26, 2024 19:49
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jonwaldstein jonwaldstein merged commit f9357c2 into epic/stripe-subscription-management Sep 26, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the refactor/move-recipient-emails-into-general-settings branch September 26, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants