-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add support for pausing/resuming subscriptions #7548
Feature: Add support for pausing/resuming subscriptions #7548
Conversation
use Give\Framework\PaymentGateways\Contracts\Subscription\SubscriptionPaymentMethodEditable; | ||
use Give\Framework\PaymentGateways\Contracts\Subscription\SubscriptionResumable; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this still?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. That's a leftover.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking, everything seems to be in order with the UI and this work. This should be good to go! Would you prefer I make an epic for the UI & this or would you rather work off dev?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
… receive an array of data
@pauloiankoski we decided to loosen the restriction on the |
89a15f3
into
epic/stripe-subscription-management
Cool. That's something I was in doubt. I see other methods receiving a generic |
@pauloiankoski yeah it's just hard to predict what params would be helpful for all gateways at this point, so i'd rather keep it flexible as changing signatures on contracts is painful 😄 |
Resolves GIVE-1250
Description
This Pull Request adds supports for gateways to implement their solutions for pausing/resuming subscriptions. Within this PR we are:
SubscriptionPausable
contract to be signed by gateways;can_pause
to gateways (false by default if not implemented);SubscriptionRepository
to update the expiration date into the database;This PR is a foundational work that is required for the new implementations on Give Recurring.
Affects
Subscriptions
Pre-review Checklist
@unreleased
tags included in DocBlocks