-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add create new campaign flow #7543
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjohnson
reviewed
Sep 26, 2024
src/Campaigns/resources/admin/components/CampaignFormModal/index.tsx
Outdated
Show resolved
Hide resolved
alaca
reviewed
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor thing. Good job, man!
alaca
reviewed
Sep 26, 2024
src/Campaigns/resources/admin/components/CampaignFormModal/index.tsx
Outdated
Show resolved
Hide resolved
kjohnson
approved these changes
Sep 27, 2024
alaca
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, man!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-1217
Description
This PR split the form to create a new campaign in two steps and add all necessary fields and styles to make it work as expected. The main goal here is to implement the functionality that allows us to run some internal tests, but we'll need to tweak some things later related to design adjustments and other improvements.
Important: Please note that I'm planning to open a subsequent PR when PR #7547 gets merged to the Epic, so I'll be able to refactor this form to use the new
@wordpress/core-data approach
used there and also will replace the Goal input to use a CurrencyInput (which is being introduced in the mentioned PR) when the "Amount raised" option is selected on the Goal Type options.Affects
The "Create New Campaign" form.
Visuals
Testing Instructions
Give > Campaigns
page;Create campaign
button;Pre-review Checklist
@unreleased
tags included in DocBlocks