Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add create new campaign flow #7543

Merged
merged 20 commits into from
Oct 1, 2024

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Sep 17, 2024

Resolves GIVE-1217

Description

This PR split the form to create a new campaign in two steps and add all necessary fields and styles to make it work as expected. The main goal here is to implement the functionality that allows us to run some internal tests, but we'll need to tweak some things later related to design adjustments and other improvements.

Important: Please note that I'm planning to open a subsequent PR when PR #7547 gets merged to the Epic, so I'll be able to refactor this form to use the new @wordpress/core-data approach used there and also will replace the Goal input to use a CurrencyInput (which is being introduced in the mentioned PR) when the "Amount raised" option is selected on the Goal Type options.

Affects

The "Create New Campaign" form.

Visuals

image

image

Testing Instructions

  1. Go to Give > Campaigns page;
  2. Click on the Create campaign button;
  3. Follow the steps to create a new campaign;
  4. Make sure everything worked as expected.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Sep 17, 2024
@glaubersilva glaubersilva marked this pull request as ready for review September 26, 2024 10:56
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing. Good job, man!

src/Campaigns/Routes/CreateCampaign.php Outdated Show resolved Hide resolved
@alaca alaca mentioned this pull request Sep 27, 2024
3 tasks
@glaubersilva
Copy link
Contributor Author

@kjohnson @alaca Thanks for the suggestion guys! This is ready for re-review.

Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, man!

@alaca alaca merged commit 67011c2 into epic/campaigns Oct 1, 2024
20 checks passed
@alaca alaca deleted the feature/new-campaign-flow-GIVE-1217 branch October 1, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants