Refactor: Update Forms to Campaigns migration #7532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjohnson
changed the title
glaubersilva
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
@kjohnson Looks good to me! I just left a comment related to a minor change, but I'll approve it to advance things.
glaubersilva
approved these changes
Sep 5, 2024
kjohnson
commented
Sep 9, 2024
kjohnson
changed the title
There was a problem hiding this comment.
@kjohnson I left a comment about the trash status, but I am not sure if my point should be a concern. So let me know your thoughts on it.
glaubersilva
approved these changes
Sep 11, 2024
JasonTheAdams
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-1178
Description
This PR updates the
migrate_forms_to_campaign_formsmigration to remove use of business logic specific code (that is prone to change/refactor) in favor of moving the data directly (or directly as possible) from one database table/column to another.Specifically, this avoids use of the
FormSettingsDTO and theCampaignmodel and repository (prone to changes), while continuing to leverageDonationStatusandCampaignStatusEnums (unlikely to change).Additionally, this PR updates the migration to add support for "upgraded" forms. This includes a secondary process in the migration that adds upgraded forms to existing campaigns alongside the form resulting from the upgrade process.
The
Campaignmodel has been updated with aform()method to get the "default" form. This is in addition to theforms()relationship method which returns a prepared query for campaign related donation forms.Pre-review Checklist
@unreleasedtags included in DocBlocks