Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add campaign details page #7531

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Sep 3, 2024

Resolves GIVE-1152

Description

This PR adds an initial campaign details page that loads a few data from the overview and settings tab and only displays on the screen in a raw format - the design should be implemented in subsequent PRs.

For reference about the information architecture, check this design prototype:
https://www.figma.com/design/KN4DmHaBWDylrq1EbVXw3n/Campaigns?node-id=299-10474&node-type=FRAME&t=7fGtZY2l39rnL5Ou-0

Affects

The campaign details page.

Visuals

image

Testing Instructions

  1. Go to Give > Campaigns page;
  2. Create a new campaign or Edit a campaign created previously;
  3. You should see a screen with details about the campaign and a link to edit the landing page;
  4. Click on the Edit Campaign Landing Page ⭷ link and a a new tab should be open.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Sep 3, 2024
Base automatically changed from feature/campaigns-list-table-GIVE-1151 to epic/campaigns September 5, 2024 07:26
@glaubersilva glaubersilva force-pushed the feature/campaigns-overview-GIVE-1152 branch from 9f7f39e to 789de37 Compare September 5, 2024 15:29
@glaubersilva glaubersilva changed the title Feature: add placeholder for campaigns overview Feature: add campaign details page Sep 5, 2024
@glaubersilva glaubersilva marked this pull request as ready for review September 5, 2024 18:26
@alaca alaca self-requested a review September 6, 2024 13:59
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few minor things I would change, but since this is just a placeholder, this is perfectly fine. Good job, man!

@glaubersilva glaubersilva merged commit e288b63 into epic/campaigns Sep 6, 2024
20 checks passed
@glaubersilva glaubersilva deleted the feature/campaigns-overview-GIVE-1152 branch September 6, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants