Create campaign tables

[alaca]

Description

This PR is reusing the give_campaigns table created by P2P. Also, it adds a new column to the give_campaigns table - campaign_type. The give_core_campaign_forms table is a lookup table that exists solely to avoid possible performance issues when using the post meta table.

Pre-review Checklist

• Relevant @unreleased tags included in DocBlocks
• Self Review of code and UX completed

[JasonTheAdams]

@alaca The intent is to re-use the existing P2P give_campaigns table, right? Ultimately, we want the two merged into a single table with a type that differentiates the various campaign types.

[alaca]

@JasonTheAdams we talked about it and the plan was to create a new table, at least I understood it like that. The campaigns table created from P2P seems too oriented on P2P (it has columns like form_id, campaign_url, etc. ) which is something we don't need here. But yeah, we can definitely make use of the give_campaigns table.

[JasonTheAdams]

@alaca I see, however I disagree with that conclusion. Ultimately, we want to be able to query all the campaigns at once. It sounds more like we need to offload some of the columns from the existing table to another P2P-specific table. It was intended to be generic when we built it, seems like some specific columns snuck their way in when we built it 3 years ago. 🤷‍♂️

[kjohnson]

My understanding was that we would migrate the table from P2P to core.

[JasonTheAdams]

@kjohnson Yeah, so we'll want to make two migrations:

1. A conditional one in core that creates the table if it doesn't already exist
2. A P2P migration to move some of the P2P-specific columns into the give_p2P_campaigns table, and moves the column data over

[alaca]

@JasonTheAdams @kjohnson okay, then we will use the existing give_campaigns table. We will just have to add some conditional stuff.

[JasonTheAdams]

Thanks @alaca! You're the best! 🙌

[JasonTheAdams]

As a note, @alaca, this is a good time to assess the existing columns — names, types, etc. — and make sure they're what we want. Since we're making migrations to move and adjust things now, best to give it some thought and not have to make more later. I think it's worth some discussion.

[alaca]

@JasonTheAdams @kjohnson I updated the table name and the columns list to be the same as the one created from P2P.
And the awesome thing here is that we don't have to add any checks because we use dbDelta. dbDelta will check if that table exists, and if not, it will create one. Also, it will check the columns and update the table if needed. So the only extra column I have to add here is campaign_type.

[kjohnson]

Approved (forgot to click this button before merging into the epic).