Fix: missing event tickets amount for PayPal one-time donations #7403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaubersilva
force-pushed
the
fix/paypal-missing-tickets-amount-GIVE-853
branch
from
b821651 to
8dd21de
Compare
JasonTheAdams
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Good work, @glaubersilva! Thanks for thinking through this together! Let's get this to QA!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-853
Description
This PR implements a fix for the bug that sends only the donation amount to PayPal and ignores the value of the event tickets associated with the donation.
Important: The fix is exclusive for one-time donations made with PayPal Donations. A subsequent PR in the recurring add-on repository will be necessary for recurring donations made with this same gateway.
Affects
One-time donations made with the PayPal Donations gateway.
Visuals
I recorded a video to discuss a possible fix for it in the recurring donations and in the first minutes I demonstrated the fix implemented by this PR as well.
Here is the link:
https://www.loom.com/share/8822471d6c5f46429a20a16aafef0627?sid=d5d128aa-d172-47f1-b28a-8074d8083285
Testing Instructions
Pre-review Checklist
@unreleasedtags included in DocBlocks